MNT: build macOS amr64 wheels without cross-compiling #4888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
added
build
neutrinoceros
force-pushed
the
mnt/macos_wheels
branch
from
c3820b5
to
95e4668
Compare
cphyc
reviewed
Apr 29, 2024
neutrinoceros
force-pushed
the
mnt/macos_wheels
branch
from
f39e4e3
to
37e9a6d
Compare
cphyc
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Now that GitHub Actions and cibuildwheel support amr64, we don't need cross compilation for these wheels, and we can lift that burden off of the macOS x86 job, which is by far the longest running job in the matrix (see for example https://github.com/yt-project/yt/actions/runs/8852696165/usage)