TST: migrate test_disks.py from nose to pytest #4897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
force-pushed
the
tst/migrate_test_disks
branch
from
e8d1528
to
157cebd
Compare
neutrinoceros
force-pushed
the
tst/migrate_test_disks
branch
from
157cebd
to
c4ce79f
Compare
neutrinoceros
added
tests: running tests
|
Looks like I forgot to undraft this. Rebased to fix a conflict. |
chrishavlin
reviewed
Jun 27, 2024
| @@ -44,3 +44,4 @@ | |||
| --ignore-file=test_minimal_representation\.py | |||
| --ignore-file=test_set_log_level\.py | |||
| --ignore-file=test_field_parsing\.py | |||
| --ignore-file=test_disks\.py | |||
There was a problem hiding this comment.
Should also this add to yt/tests/test.yaml -- though tests ran just fine, so maybe we don't need to actually be doing that anymore?
There was a problem hiding this comment.
Indeed it seems that it's not needed here, but I don't know why TBH
There was a problem hiding this comment.
well I"ll hit approve and let you decide if you want to add it down in yt/test/test.yaml as well :)
There was a problem hiding this comment.
I'd tend to say "let's not fix it if it ain't broke"
chrishavlin
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
A side product of my manual fixing of #4895