TST: cleanup unnecessary warning filter #4912
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
I am now almost sure that the comment I wrote for this filter (circa 2021) was ill-informed and misleading. Astropy's wheels in fact were already being built in a forward-compatible way with
oldest-supported-numpy
at the time and continue to be (now using the more modern mechanism introduced in numpy 1.25). I suspect the real reason why we were seeing this warning was that we installed numpy from conda and then astropy from PyPI, which we haven't been doing since #4624