add check for Sub_conventions for CFradial #4915
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrishavlin
added
enhancement
| if hasattr(ds, c): | ||
| cons += getattr(ds, c) | ||
| is_cfrad = "CF/Radial" in cons | ||
| is_cfrad = "CF/Radial" in cons or "CF-Radial" in cons |
There was a problem hiding this comment.
while your patch seems uncontroversial, I'm having trouble understand the existing implementation: why is cons constructed as a concatenated str instead of a list[str] ?
There was a problem hiding this comment.
I'll double check but I think it's because those attribute values are space-delimted strings. e.g., "CF-Radial instrument_parameters radar_parameters radar_calibration" is actually 'CF-Radial instrument_parameters radar_parameters radar_calibration' so you have to search for a substring. I'll confirm that and add a comment in the code here (or update the code if I'm wrong).
There was a problem hiding this comment.
OK: confirmed just now, and pushed up a comment so that it's clearer in the future
neutrinoceros
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the cf_radial frontend
_is_validto look in an additional attribute (Sub_conventions).NEXRAD (https://cmr.earthdata.nasa.gov/search/concepts/C2020894988-GHRC_DAAC.html) uses CFradial but has slightly different metadata from what we're checking for. In this case it's got the following attributes: