Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: replace boxlib with amrex references in the docs #4925

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

chrishavlin
Copy link
Contributor

Was building the docs locally and noticed a few spots that should be updated to reflect #4845

@neutrinoceros
Copy link
Member

This is inevitably going to hit #4924, but it's also a very timely opportunity to fix it 🤗
Can you add ipykernel to doc deps ?

@chrishavlin
Copy link
Contributor Author

sure! will add it here

@@ -558,7 +558,7 @@ using a ``parameters`` dict, accepting the following keys:
AMReX / BoxLib Data
-------------------

AMReX and BoxLib share a frontend (currently named ``boxlib``), since
AMReX and BoxLib share a frontend, since
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this sentence missing a verb ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh ya! good catch, might as well fix that too :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(but will wait to see how the docs build goes)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verb added to the next line!

@chrishavlin
Copy link
Contributor Author

just added, didn't pin it to a version though. if the docs build succeeds I can pin it to whatever version it resolves to.

@chrishavlin
Copy link
Contributor Author

chrishavlin commented Jun 13, 2024

docs build isn't done, but looks like it's chugging along just fine. I'm going to push up one more batch to fix the small typo that @neutrinoceros caught and pin ipykernel to ipykernel>=6.29.4 (which is what the version the current docs build is running with).

EDIT: got distracted and hte build finished successfully in the mean time! just pushed the pinned version

@chrishavlin chrishavlin linked an issue Jun 13, 2024 that may be closed by this pull request
@neutrinoceros neutrinoceros added this to the 4.4.0 milestone Jun 14, 2024
@neutrinoceros neutrinoceros merged commit e9ba8ac into yt-project:main Jun 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: docs builds are failing
2 participants