BLD: switch to Cython 3.0, forbid deprecated Numpy C API in generated code #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are not taking longer than usual, so I think this is good to go ? |
neutrinoceros
force-pushed
the
cython3
branch
2 times, most recently
from
f137de0
to
5b0e7be
Compare
|
I'm ok with this going in, but I don't have enough expertise in cython to comment on the question raised. |
brittonsmith
approved these changes
Aug 22, 2023
|
I would advise that, yeah. But it's probably not strictly necessary. |
|
ok done. I'll merge this and follow-up PRs when tests pass. Thank you both ! |
|
actually, this is causing compilation errors in CI, so I've reverted this part of the patch. Let's just keep in mind that this change may be the first suspect in the event of performance regressions in the near future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening as a draft. Build already works (locally) but there may be some performance regressions. Hopefully it'll show in CI.