[bugfix] fix light cone projections with weight fields #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
==========================================
+ Coverage 63.46% 65.36% +1.89%
==========================================
Files 24 24
Lines 1270 1305 +35
==========================================
+ Hits 806 853 +47
+ Misses 464 452 -12
Continue to review full report at Codecov.
|
matthewturk
approved these changes
Nov 4, 2018
| @@ -335,14 +335,9 @@ def project_light_cone(self, field_of_view, image_resolution, field, | |||
| pixel_area = (proper_box_size.in_cgs() / pixels)**2 #in proper cm^2 | |||
| factor = pixel_area / (4.0 * np.pi * dL.in_cgs()**2) | |||
| mylog.info("Distance to slice = %s" % dL) | |||
| frb[field] *= factor #in erg/s/cm^2/Hz on observer"s image plane. | |||
| frb['field'] *= factor #in erg/s/cm^2/Hz on observer"s image plane. | |||
There was a problem hiding this comment.
As long as you're changing this line, there is a double quote where a single would do
There was a problem hiding this comment.
Oh yeah, that's probably been there forever!
ngoldbaum
approved these changes
Nov 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves Issue #36. There were a few places with improper handling of the projected weight field. The behavior of the code suggests that some functionality was not updated for changes to projections, so this has likely been broken for quite some time. I'll let the test suite run and then add a new test.