for review

ytake · Dec 3, 2016 · 7da9b1e · 7da9b1e
1 parent 8ce0b20
commit 7da9b1e
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 19 deletions.
diff --git a/src/Matcher/AnnotationScanMatcher.php b/src/Matcher/AnnotationScanMatcher.php
@@ -43,16 +43,15 @@ public function __construct()
      */
     public function matchesClass(\ReflectionClass $class, array $arguments)
     {
-        $i = 0;
+        $count = 0;
         $annotation = $arguments[0];
         foreach ($class->getMethods(\ReflectionMethod::IS_PUBLIC) as $reflectionMethod) {
             $match = $this->reader->getMethodAnnotation($reflectionMethod, $annotation);
             if ($match) {
-                $i++;
+                $count++;
             }
         }
-
-        if ($i > 1) {
+        if ($count > 1) {
             return false;
         }
 
@@ -64,16 +63,16 @@ public function matchesClass(\ReflectionClass $class, array $arguments)
      */
     public function matchesMethod(\ReflectionMethod $method, array $arguments)
     {
-        $i = 0;
+        $count = 0;
         $annotation = $arguments[0];
         $reflectionClass = new \ReflectionClass($method->class);
         foreach ($reflectionClass->getMethods(\ReflectionMethod::IS_PUBLIC) as $reflectionMethod) {
             $match = $this->reader->getMethodAnnotation($reflectionMethod, $annotation);
             if ($match) {
-                $i++;
+                $count++;
             }
         }
-        if ($i > 1) {
+        if ($count > 1) {
             return false;
         }
 

diff --git a/tests/src/AspectPostConstruct.php b/tests/src/AspectPostConstruct.php
@@ -13,31 +13,31 @@
 class AspectPostConstruct
 {
     /** @var int  */
-    protected $a;
+    protected $index;
 
     /**
      * AspectPostConstruct constructor.
      *
-     * @param int $a
+     * @param int $index
      */
-    public function __construct($a = 1)
+    public function __construct($index = 1)
     {
-        $this->a = $a;
+        $this->index = $index;
     }
 
     /**
      * @PostConstruct
      */
     public function initialize()
     {
-        $this->a += 1;
+        $this->index += 1;
     }
 
     /**
      * @return int
      */
     public function getA()
     {
-        return $this->a;
+        return $this->index;
     }
 }
diff --git a/tests/src/FailedPostConstruct.php b/tests/src/FailedPostConstruct.php
@@ -13,24 +13,24 @@
 class FailedPostConstruct
 {
     /** @var int  */
-    protected $a;
+    protected $index;
 
     /**
      * FailedPostConstruct constructor.
      *
-     * @param int $a
+     * @param int $index
      */
-    public function __construct($a = 1)
+    public function __construct($index = 1)
     {
-        $this->a = $a;
+        $this->index = $index;
     }
 
     /**
      * @PostConstruct
      */
     public function initialize()
     {
-        $this->a += 1;
+        $this->index += 1;
     }
 
     /**
@@ -46,6 +46,6 @@ public function initializeTwo()
      */
     public function getA()
     {
-        return $this->a;
+        return $this->index;
     }
 }