Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to open file relative to active workspace #28

Merged
merged 3 commits into from
May 16, 2021

Conversation

felixkiss
Copy link
Contributor

This PR adds a second command (no default key binding) that starts the file picker at the root of the current workspace rather than the directory of the current file.

@ytakhs
Copy link
Owner

ytakhs commented May 15, 2021

Thank you for the PR! Looks good 👍
Could you run yarn fmt to fix the CI build?

@felixkiss
Copy link
Contributor Author

Done! Didn't trigger Node CI though 🤔

@ytakhs
Copy link
Owner

ytakhs commented May 16, 2021

Thank you for fixing!

Didn't trigger Node CI though 🤔

Oh...this is due to my having changed base branch from master to main yesterday 😓 (I forgot how the CI is triggered 🙃)
As for the format, I've confirmed it's fine locally!

@ytakhs ytakhs merged commit 475fbf0 into ytakhs:main May 16, 2021
@felixkiss felixkiss deleted the open-workspace branch May 16, 2021 10:04
@felixkiss
Copy link
Contributor Author

will you release a new version soon that contains the new command?

@ytakhs
Copy link
Owner

ytakhs commented May 20, 2021

I'm going to release it on this weekend 😄

@ytakhs
Copy link
Owner

ytakhs commented May 22, 2021

This has been released! 🎉

https://github.com/jit-y/vscode-advanced-open-file/releases/tag/v0.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants