Use octicons to denote files/directories/symlinks instead of description. #3
+8
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! I' m glad to receive PR from the author of advanced-open-file! I think I'll review this along with #4 within a week. :) |
ytakhs
requested changes
Jun 22, 2019
There was a problem hiding this comment.
There is few parts I want you to fix, otherwise it looks good to me!
Apparently you can insert icons into text labels, which seemed like a better way to denote files vs directories than the description field. Let me know what you think!
I did not insert the icon into the label simply because I did not know how to do it...
(I missed this page.)
|
Sorry for the delay, this is updated with the suggested fixes. :D |
|
Thank you for fixing!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for making a VSCode port! I had briefly tried making one myself a year or so ago and didn't really make much progress. Not having an equivalent to advanced-open-file in VSCode is one of the main reasons I still use Atom as my main editor.
Apparently you can insert icons into text labels, which seemed like a better way to denote files vs directories than the description field. Let me know what you think!