Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A little appearance problem when changing flash mode #2

Closed
ghysrc opened this issue Feb 17, 2016 · 8 comments
Closed

A little appearance problem when changing flash mode #2

ghysrc opened this issue Feb 17, 2016 · 8 comments

Comments

@ghysrc
Copy link

ghysrc commented Feb 17, 2016

iosghy02172016144050

When I clicked the flash button

iosghy02172016144059

Another problem is I think you always set the off image to flash button at the beginning no matter the flash mode is on or off.

@ytakzk
Copy link
Owner

ytakzk commented Mar 4, 2016

@ghysrc Do you use the latest version of 0.2.1? And is it reproducible on your device, not on simulator?

@ghysrc
Copy link
Author

ghysrc commented Mar 7, 2016

I install this by Cocoapods. I checked the version, it is 0.2.1.And I never use the simulator.
Besides the button problem, what I am saying is you didn't check the flash mode first, you just set the off image.
For example, I opened the FSCameraView, I turn on the flash mode, I close the FSCameraView. And when I opened the FSCameraView again, actually the flash mode is already on, but it shows the off image. Then I take a picture, I can see the flash lights of camera.

About the appearance problem, I have checked the code, I can't find any problem either.
flashButton.setImage(UIImage(named: "ic_flash_on"), forState: .Normal)
It should works. Maybe there is something different with my phone? I will test this on other devices.

@ytakzk
Copy link
Owner

ytakzk commented Mar 7, 2016

@ghysrc Thank you for sharing the bug. I am not still sure what makes the appearance problem but can fix the bug of flash light. Let me fix the bug first then move on to the appearance problem.

@ytakzk
Copy link
Owner

ytakzk commented Mar 8, 2016

@ghysrc I hope the bugs are fixed in 0.2.3. Could you check it after updating to the latest version?
At least the bug of flash light has been surely fixed.

@ytakzk ytakzk closed this as completed Mar 8, 2016
@Ferrick90
Copy link
Contributor

In 0.2.3, the flash button still appearance like that. izit image affect it??

@ytakzk
Copy link
Owner

ytakzk commented Mar 15, 2016

@Ferrick90 Do you mean you still have the appearance problem in 0.2.3?
If so, could you tell me the device reproducing the bug?

@Ferrick90
Copy link
Contributor

Yes. My iPhone 5 and iPhone 6 Plus reproducing the bug. Other devices, I don't know.

@aslisabanci
Copy link

I'm experiencing the same issue with v0.2.3 I had written the details at #10 Please let me know if you'd like more information from my side.

ytakzk pushed a commit that referenced this issue Jun 7, 2016
Add video support from waterskier2007 and add theming options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants