Skip to content

Commit

Permalink
[youtube] Remove RIAA copyrighted media from tests as per [1]
Browse files Browse the repository at this point in the history 
1. Github dmca and 1201 notice re youtube-dl 9-21-20
  • Loading branch information
@dstftw
dstftw committed Nov 16, 2020
1 parent 28f9568 commit 1fb034d
Showing 1 changed file with 1 addition and 144 deletions.
145 changes: 1 addition & 144 deletions youtube_dl/extractor/youtube.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -509,48 +509,6 @@ class YoutubeIE(YoutubeBaseInfoExtractor):
'end_time': 9,
}
},
{
'url': 'https://www.youtube.com/watch?v=UxxajLWwzqY',
'note': 'Test generic use_cipher_signature video (#897)',
'info_dict': {
'id': 'UxxajLWwzqY',
'ext': 'mp4',
'upload_date': '20120506',
'title': 'Icona Pop - I Love It (feat. Charli XCX) [OFFICIAL VIDEO]',
'alt_title': 'I Love It (feat. Charli XCX)',
'description': 'md5:19a2f98d9032b9311e686ed039564f63',
'tags': ['Icona Pop i love it', 'sweden', 'pop music', 'big beat records', 'big beat', 'charli',
'xcx', 'charli xcx', 'girls', 'hbo', 'i love it', "i don't care", 'icona', 'pop',
'iconic ep', 'iconic', 'love', 'it'],
'duration': 180,
'uploader': 'Icona Pop',
'uploader_id': 'IconaPop',
'uploader_url': r're:https?://(?:www\.)?youtube\.com/user/IconaPop',
'creator': 'Icona Pop',
'track': 'I Love It (feat. Charli XCX)',
'artist': 'Icona Pop',
}
},
{
'url': 'https://www.youtube.com/watch?v=07FYdnEawAQ',
'note': 'Test VEVO video with age protection (#956)',
'info_dict': {
'id': '07FYdnEawAQ',
'ext': 'mp4',
'upload_date': '20130703',
'title': 'Justin Timberlake - Tunnel Vision (Official Music Video) (Explicit)',
'alt_title': 'Tunnel Vision',
'description': 'md5:07dab3356cde4199048e4c7cd93471e1',
'duration': 419,
'uploader': 'justintimberlakeVEVO',
'uploader_id': 'justintimberlakeVEVO',
'uploader_url': r're:https?://(?:www\.)?youtube\.com/user/justintimberlakeVEVO',
'creator': 'Justin Timberlake',
'track': 'Tunnel Vision',
'artist': 'Justin Timberlake',
'age_limit': 18,
}
},
{
'url': '//www.YouTube.com/watch?v=yZIXLfi8CZQ',
'note': 'Embed-only video (#1746)',
Expand All @@ -567,7 +525,7 @@ class YoutubeIE(YoutubeBaseInfoExtractor):
}
},
{
'url': 'https://www.youtube.com/watch?v=BaW_jenozKc&v=UxxajLWwzqY',
'url': 'https://www.youtube.com/watch?v=BaW_jenozKc&v=yZIXLfi8CZQ',
'note': 'Use the first video ID in the URL',
'info_dict': {
'id': 'BaW_jenozKc',
Expand Down Expand Up @@ -626,24 +584,6 @@ class YoutubeIE(YoutubeBaseInfoExtractor):
'format': '141/bestaudio[ext=m4a]',
},
},
# JS player signature function name containing $
{
'url': 'https://www.youtube.com/watch?v=nfWlot6h_JM',
'info_dict': {
'id': 'nfWlot6h_JM',
'ext': 'm4a',
'title': 'Taylor Swift - Shake It Off',
'description': 'md5:307195cd21ff7fa352270fe884570ef0',
'duration': 242,
'uploader': 'TaylorSwiftVEVO',
'uploader_id': 'TaylorSwiftVEVO',
'upload_date': '20140818',
},
'params': {
'youtube_include_dash_manifest': True,
'format': '141/bestaudio[ext=m4a]',
},
},
# Controversy video
{
'url': 'https://www.youtube.com/watch?v=T4XJQO3qol8',
Expand Down Expand Up @@ -675,22 +615,6 @@ class YoutubeIE(YoutubeBaseInfoExtractor):
'age_limit': 18,
},
},
# Age-gate video with encrypted signature
{
'url': 'https://www.youtube.com/watch?v=6kLq3WMV1nU',
'info_dict': {
'id': '6kLq3WMV1nU',
'ext': 'mp4',
'title': 'Dedication To My Ex (Miss That) (Lyric Video)',
'description': 'md5:33765bb339e1b47e7e72b5490139bb41',
'duration': 246,
'uploader': 'LloydVEVO',
'uploader_id': 'LloydVEVO',
'uploader_url': r're:https?://(?:www\.)?youtube\.com/user/LloydVEVO',
'upload_date': '20110629',
'age_limit': 18,
},
},
# video_info is None (https://github.com/ytdl-org/youtube-dl/issues/4421)
# YouTube Red ad is not captured for creator
{
Expand Down Expand Up @@ -1105,73 +1029,6 @@ class YoutubeIE(YoutubeBaseInfoExtractor):
'skip_download': True,
},
},
{
# Youtube Music Auto-generated description
# Retrieve 'artist' field from 'Artist:' in video description
# when it is present on youtube music video
'url': 'https://www.youtube.com/watch?v=k0jLE7tTwjY',
'info_dict': {
'id': 'k0jLE7tTwjY',
'ext': 'mp4',
'title': 'Latch Feat. Sam Smith',
'description': 'md5:3cb1e8101a7c85fcba9b4fb41b951335',
'upload_date': '20150110',
'uploader': 'Various Artists - Topic',
'uploader_id': 'UCNkEcmYdjrH4RqtNgh7BZ9w',
'artist': 'Disclosure',
'track': 'Latch Feat. Sam Smith',
'album': 'Latch Featuring Sam Smith',
'release_date': '20121008',
'release_year': 2012,
},
'params': {
'skip_download': True,
},
},
{
# Youtube Music Auto-generated description
# handle multiple artists on youtube music video
'url': 'https://www.youtube.com/watch?v=74qn0eJSjpA',
'info_dict': {
'id': '74qn0eJSjpA',
'ext': 'mp4',
'title': 'Eastside',
'description': 'md5:290516bb73dcbfab0dcc4efe6c3de5f2',
'upload_date': '20180710',
'uploader': 'Benny Blanco - Topic',
'uploader_id': 'UCzqz_ksRu_WkIzmivMdIS7A',
'artist': 'benny blanco, Halsey, Khalid',
'track': 'Eastside',
'album': 'Eastside',
'release_date': '20180713',
'release_year': 2018,
},
'params': {
'skip_download': True,
},
},
{
# Youtube Music Auto-generated description
# handle youtube music video with release_year and no release_date
'url': 'https://www.youtube.com/watch?v=-hcAI0g-f5M',
'info_dict': {
'id': '-hcAI0g-f5M',
'ext': 'mp4',
'title': 'Put It On Me',
'description': 'md5:f6422397c07c4c907c6638e1fee380a5',
'upload_date': '20180426',
'uploader': 'Matt Maeson - Topic',
'uploader_id': 'UCnEkIGqtGcQMLk73Kp-Q5LQ',
'artist': 'Matt Maeson',
'track': 'Put It On Me',
'album': 'The Hearse',
'release_date': None,
'release_year': 2018,
},
'params': {
'skip_download': True,
},
},
{
'url': 'https://www.youtubekids.com/watch?v=3b8nCWDgZ6Q',
'only_matching': True,
Expand Down

55 comments on commit 1fb034d

@kattjevfel
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers I'll drink to that bro

@atastycookie
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hoooray!

@savi2w
Copy link

@savi2w savi2w commented on 1fb034d Nov 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

@bnb
Copy link

@bnb bnb commented on 1fb034d Nov 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Deshdeepak1
Copy link

@Deshdeepak1 Deshdeepak1 commented on 1fb034d Nov 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome back. 🥳

@YousufSSyed
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice.

@umbresp
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pog

@iuriguilherme
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lesson for the next generation: a simple commit is a better use of the human brain than a take down letter

@rautamiekka
Copy link
Contributor

@rautamiekka rautamiekka commented on 1fb034d Nov 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Petty things as per RIAA's pre-established stupidity: a multi-site downloader ain't a problem, but downloading RIAA's shit as part of automated tests is. Petty stupidity at its finest.

Speaking of which, I read youtube-dl repo was totally deleted, not simply hidden. I guess the source had no idea what they were saying.

@iuriguilherme
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Speaking of which, I read youtube-dl repo was totally deleted, not simply hidden. I guess the source had no idea what they were saying.

While that is true, it is also true that there's no such thing as deleting files. Github repositories that can't be found on disk cache, raids or tape backups are still in the artic

@LaxWasHere
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¯\_(ツ)_/¯

@Zaryob
Copy link

@Zaryob Zaryob commented on 1fb034d Nov 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it was caused Just a link its really annoying.

@majestrate
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lesson for the next generation: a simple commit is a better use of the human brain than a take down letter

they should've just made an issue about it.

@rautamiekka
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lesson for the next generation: a simple commit is a better use of the human brain than a take down letter

they should've just made an issue about it.

Too much to ask of RIAA in their mind, despite a DMCA being order of magnitude more work.

@CatboyCoding
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pog

@exikyut
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the noted videos were used solely because they exhibited technically interesting special-case behaviors. Given that (I don't think) there's a straightforward (or any) way to search YouTube for videos like these, it would be really cool if some nice person at Y or G could maybe drop some hints about good alternatives.

@fsktom
Copy link

@fsktom fsktom commented on 1fb034d Nov 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! :D

@Sobsz
Copy link

@Sobsz Sobsz commented on 1fb034d Nov 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the noted videos were used solely because they exhibited technically interesting special-case behaviors. Given that (I don't think) there's a straightforward (or any) way to search YouTube for videos like these, it would be really cool if some nice person at Y or G could maybe drop some hints about good alternatives.

i'd imagine only popular videos owned by record labels have that sort of protection so i doubt that'd be possible

@boredness
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toasting in this bread

@slch
Copy link

@slch slch commented on 1fb034d Nov 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really enough? Congrats though.

@ckcr4lyf
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats 🥂

@pjtnt11
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LETS GO! POGGERS

@mustafababil
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super good news 🍻

@Stradi
Copy link

@Stradi Stradi commented on 1fb034d Nov 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome back 🍾

@Kagami
Copy link
Contributor

@Kagami Kagami commented on 1fb034d Nov 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, downloading of those VEVO videos still works, just checked few links.
So what did RIAA really accomplish by that?

@orges
Copy link

@orges orges commented on 1fb034d Nov 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@resynth1943
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hats off to @nat and @dstftw, amazing job guys 👋

Let's hope these pernicious record labels won't return for another fruitless attack on open-source.

@Evernow
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, downloading of those VEVO videos still works, just checked few links.
So what did RIAA really accomplish by that?

Nothing. RIAA are a bunch of dumbasses.

I hope youtube-dl moves to a selfhosted gitlab instance, hosted by someone like njal.la who publicly tells DMCAs to fuck off: https://njal.la/blog/about-those-threats/

@stingalleman
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOOOP WOOOP

@twl-surrogate
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BITCH IM BACK OUT MY COMA

@derjp
Copy link

@derjp derjp commented on 1fb034d Nov 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, EFF 👍

@rafaelwastaken
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bless the EFF https://github.com/github/dmca/blob/master/2020/11/2020-11-16-RIAA-reversal-effletter.pdf

@faissaloo
Copy link

@faissaloo faissaloo commented on 1fb034d Nov 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Daily reminder that 'intellectual property' isn't real and the people who enforce it are spooked and cringe

@B0pol
Copy link
Contributor

@B0pol B0pol commented on 1fb034d Nov 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Donate to EFF

@BenLubar
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lesson for the next generation: a simple commit is a better use of the human brain than a take down letter

they should've just made an issue about it.

The DMCA policies page on GitHub's support site includes at least three bullet points that the RIAA seems to have violated.

image

Not that there will ever be any consequence for violating the rules if you're the RIAA, but still.

@dilworks
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be fair, I would have NOT deleted the testcases - caving to the MAFIAA is never an option! Stick it to the man, etc.

(But then, if you're insane enough to download Timberlake/Swift/whatever the hell is "Icona Pop" music, well... don't expect any sympathy from me - I don't consume Hollywood for very good reasons).

Consider seriously GTFO GiggityHub (but not to a Chinese server - you would be trading powerful enemies!), for this and many other reasons (their website constantly breaking on non-Chromium/latest Firefox browsers being a good one, for example)

@el-f
Copy link

@el-f el-f commented on 1fb034d Nov 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return of The King

@james3126
Copy link

@james3126 james3126 commented on 1fb034d Nov 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am here simply to comment on a piece of history, and congratulate open source devs world-wide. Long live youtube-dl!

@Sanaki
Copy link

@Sanaki Sanaki commented on 1fb034d Nov 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the noted videos were used solely because they exhibited technically interesting special-case behaviors. Given that (I don't think) there's a straightforward (or any) way to search YouTube for videos like these, it would be really cool if some nice person at Y or G could maybe drop some hints about good alternatives.

i'd imagine only popular videos owned by record labels have that sort of protection so i doubt that'd be possible

Finding a video with such protections will always be an issue, since those protections exist for a reason. But are the same protections not possible to reimplement on a channel controlled by youtube-dl?

@jamesmacwhite
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Justice! Only commenting as it's an important moment for open source and such a blatant abuse of DMCA, not that RIAA is going to be brought up on it, but still fuck you RIAA.

Thank you EFF, GitHub and to all devs for their work on youtube-dl.

@813gan
Copy link

@813gan 813gan commented on 1fb034d Nov 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lawyers are funny. You should comment this code instead removing it just to make them to spend more money on damn few URLs

@MrYakobo
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icona Pop and Justin Timberlake with friends caused all this mess?? Jeez

@GriceTurrble
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome back. That's all. 👍

@0x08088405
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's quite incredible that these money grubbing pieces of garbage will sift through the program test cases to find a reason to take projects down.

@AraHaan
Copy link

@AraHaan AraHaan commented on 1fb034d Nov 17, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof in that case why even have youtube give you urls to videos then, or why the fuck did they not remove the videos to the RIAA content from youtube themsleves instead of sending a fucking dmca to here...

Like take down the fucking videos not a fucking api that thousands if not millions of developers like me use just because of it's test suite 🤣 why you think they call them a test suit for a reason RIAA? Seriosuly I think the people who work for RIAA is either braindead or do not know wtf they are doing. Its like those people who are making a law that is for short called "F.U.T.A" and then get surprised later by google at all of the p**n that share the same name as it's also the name of a type of p**n which is hillarious.

However it's not funny though because what if a kid goes to try to search that law up and then get surprised by some really questionable crap. Like seriously even they need to come up with better abreviations for laws or better names for them that do not end up getting confused with terms used for things like the name of a type of p**n.

@castle-lemongrab
Copy link

@castle-lemongrab castle-lemongrab commented on 1fb034d Nov 17, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.youtube.com/watch?v=UxxajLWwzqY

Serve me my DMCA notice, RIAA. What I just did here isn't any different than the youtube-dl team did.

@robbyoconnor
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be reverted lol

@viliml
Copy link

@viliml viliml commented on 1fb034d Nov 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be fair, I would have NOT deleted the testcases - caving to the MAFIAA is never an option! Stick it to the man, etc.

(But then, if you're insane enough to download Timberlake/Swift/whatever the hell is "Icona Pop" music, well... don't expect any sympathy from me - I don't consume Hollywood for very good reasons).

Consider seriously GTFO GiggityHub (but not to a Chinese server - you would be trading powerful enemies!), for this and many other reasons (their website constantly breaking on non-Chromium/latest Firefox browsers being a good one, for example)

10 GitHub employees downvoted this.

@DanGamingTV
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a poggers moment

@Froosk
Copy link

@Froosk Froosk commented on 1fb034d Nov 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers

@mk-pmb
Copy link
Contributor

@mk-pmb mk-pmb commented on 1fb034d Nov 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks EFF and ytdl devs!

@iuriguilherme
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plot twist: Justin Timberlake sent an e-mail to Microsoft complaining that he somehow lost the ability to stream "Cry me a river" through his python console. Now it's fixed.

@hsvikum
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this repo is in the arctic code vault.And if the copyright strike stands for some reason.Will the film of code need to be destroyed too.Probably the films contain enough pop culture references in the codes where there is a probability there may be a fully legitimate copyright strike in one of the many repos.
Food for thought.🤯

@robbyoconnor
Copy link

@robbyoconnor robbyoconnor commented on 1fb034d Nov 19, 2020 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rqu
Copy link

@rqu rqu commented on 1fb034d Nov 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

git clone https://github.com/ytdl-org/youtube-dl
git -C youtube-dl checkout 1fb034d^

Please sign in to comment.