Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[common] _parse_mpd_formats doesn't handle range-based segment lists #13784

Closed
glogachov opened this issue Jul 31, 2017 · 1 comment · Fixed by #32710
Closed

[common] _parse_mpd_formats doesn't handle range-based segment lists #13784

glogachov opened this issue Jul 31, 2017 · 1 comment · Fixed by #32710
Labels
bug fixed mpd

Comments

@glogachov
Copy link

this site has changed streaming procedure at 2007/7/31

youtube-dl.exe http://www.thisav.com/video/300708/99-06-0776.html --verbose
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['http://www.thisav.com/video/300708/99-06-0776.html', '--verbose']
[debug] Encodings: locale cp932, fs mbcs, out cp932, pref cp932
[debug] youtube-dl version 2017.07.30.1
[debug] Python version 3.4.4 - Windows-7-6.1.7601-SP1
[debug] exe versions: none
[debug] Proxy map: {}
[ThisAV] 300708: Downloading webpage
[ThisAV] 300708: Downloading MPD manifest
ERROR: An extractor error has occurred. (caused by KeyError('sourceURL',)); please report this issue on https://yt-dl.org/bug
. Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose
flag and include its complete output.
Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfdfxmx88\build\youtube_dl\extractor\common.py", line 433
, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfdfxmx88\build\youtube_dl\extractor\thisav.py", line 53,
in _real_extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfdfxmx88\build\youtube_dl\extractor\common.py", line 216
4, in _parse_html5_media_entries
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfdfxmx88\build\youtube_dl\extractor\common.py", line 212
5, in _media_formats
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfdfxmx88\build\youtube_dl\extractor\common.py", line 173
7, in _extract_mpd_formats
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfdfxmx88\build\youtube_dl\extractor\common.py", line 187
1, in _parse_mpd_formats
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfdfxmx88\build\youtube_dl\extractor\common.py", line 179
8, in extract_multisegment_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfdfxmx88\build\youtube_dl\extractor\common.py", line 179
3, in extract_Initialization
KeyError: 'sourceURL'
Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfdfxmx88\build\youtube_dl\extractor\common.py", line 433
, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfdfxmx88\build\youtube_dl\extractor\thisav.py", line 53,
in _real_extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfdfxmx88\build\youtube_dl\extractor\common.py", line 216
4, in _parse_html5_media_entries
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfdfxmx88\build\youtube_dl\extractor\common.py", line 212
5, in _media_formats
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfdfxmx88\build\youtube_dl\extractor\common.py", line 173
7, in _extract_mpd_formats
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfdfxmx88\build\youtube_dl\extractor\common.py", line 187
1, in _parse_mpd_formats
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfdfxmx88\build\youtube_dl\extractor\common.py", line 179
8, in extract_multisegment_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfdfxmx88\build\youtube_dl\extractor\common.py", line 179
3, in extract_Initialization
KeyError: 'sourceURL'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfdfxmx88\build\youtube_dl\YoutubeDL.py", line 776, in ex
tract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfdfxmx88\build\youtube_dl\extractor\common.py", line 446
, in extract
youtube_dl.utils.ExtractorError: An extractor error has occurred. (caused by KeyError('sourceURL',)); please report this issu
e on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call yout
ube-dl with the --verbose flag and include its complete output.
@mogu1121
Copy link

mogu1121 commented Aug 2, 2017

310005.mpd > 310005_dashinit.mp4

@yan12125 yan12125 changed the title thisAV:unable to download meg dash streaming [common] _parse_mpd_formats doesn't handle range-based segment lists Aug 11, 2017
jaykbull added a commit to jaykbull/youtube-dl that referenced this issue Nov 1, 2017
@jaykbull
Ignore missing attributes in MPD manifests.
ecccfc8 
Some sites, like thisav, does not include all expected attributes in
their MPD manifests.

I don't know the MPD/DASH spec at all, so I can't tell if this makes
the manifest itself non-compliant... That said, it works when played
in a browser.

By not treating this attributes as not required in code and simply
moving along when we cannot find them, we seem to be able to
successfully download videos from such sites.

This closes ytdl-org/youtube-dl#13784.
@jaykbull jaykbull mentioned this issue Nov 1, 2017
Closed
3 tasks
@dirkf dirkf mentioned this issue Jan 27, 2024
Merged
11 tasks
@dirkf dirkf added the fixed label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug fixed mpd
Projects
None yet
Milestone
No milestone
5 participants
@dirkf @yan12125 @mogu1121 @glogachov and others