[Instagram] Extract comments #10788
Merged
[Instagram] Extract comments #10788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yan12125
reviewed
Sep 28, 2016
| @@ -0,0 +1 @@ | |||
| {"http_headers": {"User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20150101 Firefox/47.0 (Chrome)", "Accept-Charset": "ISO-8859-1,utf-8;q=0.7,*;q=0.7", "Accept": "text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8", "Accept-Language": "en-us,en;q=0.5", "Accept-Encoding": "gzip, deflate"}, "playlist_index": null, "webpage_url_basename": "BKhrorNBKyV", "description": "@kingsofleon with my favourite people \ud83d\udcf9\ud83d\udca5\ud83d\udc99\ud83d\udc99\ud83d\udc99@dimitribasil @laura_go_run @soopercooper_", "format_id": "0", "extractor": "Instagram", "comment_count": 26, "display_id": "BKhrorNBKyV", "format": "0 - unknown", "_filename": "Video by carolinemonteithwilson-BKhrorNBKyV.mp4", "webpage_url": "https://www.instagram.com/p/BKhrorNBKyV/?taken-by=carolinemonteithwilson", "id": "BKhrorNBKyV", "title": "Video by carolinemonteithwilson", "thumbnails": [{"url": "https://scontent-amt2-1.cdninstagram.com/t51.2885-15/s1080x1080/e15/fr/14280457_305399146494488_2085348421_n.jpg?ig_cache_key=MTM0MjU0NjA3NTEwMTQ3Mzk0MQ%3D%3D.2", "id": "0"}], "uploader_id": "carolinemonteithwilson", "protocol": "https", "timestamp": 1474263985, "extractor_key": "Instagram", "ext": "mp4", "upload_date": "20160919", "thumbnail": "https://scontent-amt2-1.cdninstagram.com/t51.2885-15/s1080x1080/e15/fr/14280457_305399146494488_2085348421_n.jpg?ig_cache_key=MTM0MjU0NjA3NTEwMTQ3Mzk0MQ%3D%3D.2", "url": "https://scontent-amt2-1.cdninstagram.com/t50.2886-16/14406433_1764201343843456_1242211862_n.mp4", "uploader": "carolinemonteithwilson", "playlist": null, "fulltitle": "Video by carolinemonteithwilson", "like_count": 216} | |||
TRox1972
force-pushed
the
instagram_comments
branch
from
f1e19d5
to
3ae8e8c
Compare
yan12125
requested changes
Sep 28, 2016
| 'id': comment.get('id'), | ||
| 'text': comment.get('text'), | ||
| 'timestamp': int_or_none(comment.get('created_at')), | ||
| } for comment in media.get('comments', {}).get('nodes', {})] |
There was a problem hiding this comment.
I've updated previous test cases. Is that ok?
TRox1972
force-pushed
the
instagram_comments
branch
3 times, most recently
from
a8eb6f5
to
bfb08ac
Compare
yan12125
reviewed
Sep 28, 2016
| 'author': comment.get('user', {}).get('username'), | ||
| 'author_id': comment.get('user', {}).get('id'), | ||
| 'id': comment.get('id'), | ||
| 'text': comment.get('text'), |
There was a problem hiding this comment.
Either text or html is mandatory.
TRox1972
force-pushed
the
instagram_comments
branch
from
bfb08ac
to
a56e74e
Compare
yan12125
approved these changes
Sep 29, 2016
|
Merged thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
This adds support for comments extraction for Instagram