[Instagram] Extract video dimensions #10790
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstftw
requested changes
Sep 28, 2016
| formats = [{ | ||
| 'url': self._og_search_video_url(webpage, secure=False), | ||
| 'height': int_or_none(media.get('dimensions', {}).get('height')), | ||
| 'width': int_or_none(media.get('dimensions', {}).get('width')), |
| formats = [{ | ||
| 'url': media.get('video_url'), | ||
| 'height': int_or_none(media.get('dimensions', {}).get('height')), | ||
| 'width': int_or_none(media.get('dimensions', {}).get('width')), |
TRox1972
force-pushed
the
instagram_dimension
branch
2 times, most recently
from
ab85482
to
2c18e1a
Compare
dstftw
requested changes
Sep 29, 2016
| 'url': self._og_search_video_url(webpage, secure=False), | ||
| 'height': height, | ||
| 'width': width, | ||
| }] |
There was a problem hiding this comment.
Nothing really changed. You construct the same structure two times.
There was a problem hiding this comment.
does it look better now?
There was a problem hiding this comment.
Why not just
video_url = ...
width = ...
height = ...
...
if not video_url:
video_url = ...
...
formats = [{
'url': video_url,
'width': width,
'height': height,
}]
There was a problem hiding this comment.
That does seem better. Thanks, applied
TRox1972
force-pushed
the
instagram_dimension
branch
2 times, most recently
from
df13bf3
to
4f57e36
Compare
dstftw
requested changes
Sep 29, 2016
| formats = [{ | ||
| 'url': video_url, | ||
| 'width': width, | ||
| 'height': height, |
There was a problem hiding this comment.
Dimensions are uninitialized when media is not available.
TRox1972
force-pushed
the
instagram_dimension
branch
from
4f57e36
to
695e18b
Compare
|
Cherry-picked in 1609782, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Extracts dimensions from Instagram videos.