Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[adobepass] Allow new Comcast auto login message #11080

Closed
wants to merge 3 commits into from
Closed

[adobepass] Allow new Comcast auto login message #11080

wants to merge 3 commits into from

Conversation

raleeper
Copy link
Contributor

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Comcast changed the webpage for the auto login process. There is new text for the message notifying you that you have been logged in and a there is a new way to specify the redirection to the confirmation page.

I don't know if Comcast rolls out changes like this nationally or region by region, therefore I left the old code there as a fallback.

@sclower I would appreciate if you could try this version since the core team has no way to test the Comcast-specific parts.

@sclower
Copy link

sclower commented Oct 30, 2016

I'm unsure which login sequence I was given, but I patched in your
change and it's still working for me.

@raleeper
Copy link
Contributor Author

@sclower Thanks. Still working sounds pretty good!
If you see a 'Confirming auto login [1]' message in the output then you got the new auto login response.
'Confirming auto login [2]' indicates the old response.
'Logging in' means it had to send a user and pw to do a manual login.

If you had an unexpired previously cached token, it would use that and skip all of the login prompting. I do this (on Windows) to test cached and uncached logins:

rem From a Comcast IP, this video gets an auto login sequence: http://www.usanetwork.com/mrrobot/videos/eps29pyth0n-pt2p7z
python youtube_dl__main__.py --rm-cache -F --verbose --skip-download "http://www.usanetwork.com/mrrobot/videos/eps29pyth0n-pt2p7z"
python youtube_dl__main__.py -F --verbose --skip-download "http://www.usanetwork.com/mrrobot/videos/eps29pyth0n-pt2p7z"
rem From a Comcast IP, this video does a normal login form with a confirmation: http://www.syfy.com/vanhelsing/videos/105-fear-her
python youtube_dl__main__.py --rm-cache -F --verbose --skip-download "http://www.syfy.com/vanhelsing/videos/105-fear-her"
python youtube_dl__main__.py -F --verbose --skip-download "http://www.syfy.com/vanhelsing/videos/105-fear-her"

@raleeper
Copy link
Contributor Author

This is really outdated. Closing and removing the fork.

@raleeper raleeper closed this Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants