[PlaysTVIE] Fix for plays.tv extractor, adding additional tests #11165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yan12125
requested changes
Nov 12, 2016
| 'content'), video_id)['content'] | ||
| content = self._search_regex( | ||
| r'<script class=\"linked_data\" type=\"application\/ld\+json\">{(.+?)}<\/script>', webpage, 'content') | ||
| content = self._parse_json("{" + content + "}", video_id) |
There was a problem hiding this comment.
_search_json_ld may be useful here
| 'info_dict': { | ||
| 'id': '58236095d388d140aa', | ||
| 'ext': 'mp4', | ||
| 'title': 'akn3ex - \u63a7\u3048\u3081\u306b\u8a00\u3063\u3066\u9811\u5f35\u3063\u3066\u308b', |
There was a problem hiding this comment.
Just put original texts: 控えめに言って頑張ってる
| 'title': 'SavageIs - pro abortion propaganda', | ||
| 'description': 'Posted by SavageIs', | ||
| } | ||
| }] |
There was a problem hiding this comment.
Are those test cases different in terms of how videos are extracted? If so please add some comments in each test case. Otherwise just leave one test case.
There was a problem hiding this comment.
I removed the tests since it's the same extraction. My original thought was to have separate test cases for:
- http vs https
- non-ascii characters
- Verified account vs standard user account (for example, some sites might in the future force ads or additional DRM/prevent downloads of only verified accounts or high profile accounts or partners)
But the extraction method is same, so removed.
|
Cherry-picked, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Plays.tv format changed, previous extractor throws errors (
R.bindContent*from the original IE no longer exists anywhere on the page)Added additional tests, including one for non-English characters