Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

richannel Add new extractor #11259

Closed
wants to merge 2 commits into from
Closed

Conversation

mcjevans
Copy link

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.

I want to add support for the Royal Institute Christmas Lectures as described in Issue 4739. The extractor locates and passes along the location of an MP4 file hosted on the site itself that the HTML5 player displays.

@dstftw
Copy link
Collaborator

dstftw commented Nov 21, 2016

Carefully read new extractor tutorial and youtube-dl coding conventions and fix your code to follow the conventions.

@mcjevans
Copy link
Author

mcjevans commented Dec 1, 2016

As near as I can tell, it's only failing because it's running out of time. And it's running out of time because it takes so long to run through every test. When the tutorial says to "Add an import in youtube_dl/extractor/extractors.py" did it really mean to only put my import in the extractors.py file I add?

@mpenkov
Copy link

mpenkov commented Jul 24, 2018

Just checking up on this PR. Travis CI builds are failing, but there is nothing in the logs at all - they are empty. Perhaps the builds are (were?) failing because of a problem in Travis CI, not a problem in the PR? Could we try a rebuild to confirm whether that's the case?

The PR looks good otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defunct PR source branch is not accessible pending-fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants