Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PornFlip] Bug Fix (Closes #14405) #14406

Merged
merged 3 commits into from Oct 6, 2017
Merged

[PornFlip] Bug Fix (Closes #14405) #14406

merged 3 commits into from Oct 6, 2017

Conversation

jaykay12
Copy link
Contributor

@jaykay12 jaykay12 commented Oct 4, 2017

Before submitting the pull request I have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this Bug Fix and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

RESOLVED #14405

@jaykay12 jaykay12 changed the title Modified Regex [PornFlip] Modified Regex Oct 4, 2017
@jaykay12 jaykay12 changed the title [PornFlip] Modified Regex [PornFlip] Bug Fix Oct 4, 2017
@jaykay12 jaykay12 changed the title [PornFlip] Bug Fix [PornFlip] Bug Fix (Closes #14405) Oct 4, 2017
@dstftw
Copy link
Collaborator

dstftw commented Oct 4, 2017

  1. flake8.
  2. Duplicate tests.

@jaykay12
Copy link
Contributor Author

jaykay12 commented Oct 4, 2017

Okay! Let me check for flake8 😊
But I am unable to understand what you mean by duplicate tests? The 2nd test I added differs in the regex pattern from all the first one.

@dstftw
Copy link
Collaborator

dstftw commented Oct 4, 2017

It tests the same extraction scenario.

@jaykay12
Copy link
Contributor Author

jaykay12 commented Oct 4, 2017

Yeahh I does. So, what should I do now?
Should I remove the test I added?
I thought it will be cool to have a new test for such a new sort of url & wasn't aware about the fact that all tests should follow atleast different extraction methods. apologies. 😞

@dstftw
Copy link
Collaborator

dstftw commented Oct 4, 2017

Make them only matching.

@jaykay12
Copy link
Contributor Author

jaykay12 commented Oct 5, 2017

ping @dstftw

@dstftw dstftw merged commit 2e2a8e9 into ytdl-org:master Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ PornFlip ] Regex Invalid
2 participants