[ENSSavoirs] Add new extractor #14597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstftw
requested changes
Oct 27, 2017
| @@ -180,7 +180,7 @@ class InfoExtractor(object): | |||
| The following fields are optional: | |||
|
|
|||
| alt_title: A secondary title of the video. | |||
| display_id An alternative identifier for the video, not necessarily | |||
| display_id: An alternative identifier for the video, not necessarily | |||
There was a problem hiding this comment.
Don't mix unrelated changes in single PR.
| from .common import InfoExtractor | ||
|
|
||
|
|
||
| class ENSSavoirsIE(InfoExtractor): |
There was a problem hiding this comment.
jwplayer extraction code in generic extractor should be improved instead of adding this new extractor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have:
At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
Searched the bugtracker for similar pull requests
Checked the code with flake8
I am the original author of this code and I am willing to release it under Unlicense
What is the purpose of your pull request?
Description of your pull request and other information
New extractor for the site of the prestigious ENS french school.