[ccma] fix extractor. A list of urls is now being sent from the server. #15931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstftw
requested changes
Mar 24, 2018
youtube_dl/extractor/ccma.py
Outdated
| formats.append({ | ||
| 'format_id': profile, | ||
| 'url': _url['file'], | ||
| 'quality': q, |
There was a problem hiding this comment.
No, parse height from label.
There was a problem hiding this comment.
I'm sorry, but i don't understand what do you mean by height and label, could you elaborate?
youtube_dl/extractor/ccma.py
Outdated
| for _url in media_url: | ||
| formats.append({ | ||
| 'format_id': profile, | ||
| 'url': _url['file'], |
There was a problem hiding this comment.
Must not break extraction if missing.
youtube_dl/extractor/ccma.py
Outdated
| 'quality': q, | ||
| }) | ||
| q += 1 | ||
| elif media_url and isinstance(media_url, str): |
|
The last commit should address the changes requested. |
dstftw
requested changes
Mar 31, 2018
youtube_dl/extractor/ccma.py
Outdated
| if media_url and isinstance(media_url, list): | ||
| for _url in media_url: | ||
| if 'label' in _url: | ||
| height = int_or_none(_url.get('label').replace('p', '')) |
youtube_dl/extractor/ccma.py
Outdated
| if media_url: | ||
| ext = media_data.get('media', {}).get('format') | ||
| if ext: | ||
| ext = ext.lower() |
There was a problem hiding this comment.
It's already contained in video URL. Remove.
youtube_dl/extractor/ccma.py
Outdated
| 'url': sub_url, | ||
| }) | ||
| 'url': sub_url, | ||
| }) |
youtube_dl/extractor/ccma.py
Outdated
|
|
||
| formats.append({ | ||
| 'format_id': profile, | ||
| 'url': _url.get('file'), |
There was a problem hiding this comment.
Do I default to an empty string then? Or do not append if _url.get('file') returns None?
|
@dstftw I've made the changes you requested, please take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.