Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[teamcoco] fix and improve extraction #17101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[teamcoco] fix and improve extraction #17101

wants to merge 1 commit into from

Conversation

gfabiano
Copy link
Contributor

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Fix extraction, KeyError exception. ( closes #17099 )

@jmraker
Copy link

jmraker commented Sep 24, 2018

The site changed again and this unreleased fix is broken. Now the video urls are in a json response from http://teamcoco.com/_truman/d/104328 where the 104328 number is a video id that is/was probably parsed.

{"meta":{"useFreewheel":false,"freewheelId":"tbs-node-104328","turnerMediaId":null,"turnerMediaAuthToken":"","duration":"0:02:25","poster":{"url":"http://cdn.teamcococdn.com/image/640x360,frame:1/1189-comedy-5-5b53f952bc599.png"},"src":{"hd":{"label":"hd","src":"https://ak-storage-west.teamcococdn.com/cdn/2018-07/104328/bca7/CONAN_072218_Comedy_5-high.mp4","type":"video/mp4"},"sd":{"label":"sd","src":"https://ak-storage-west.teamcococdn.com/cdn/2018-07/104328/bca7/CONAN_072218_Comedy_5-standard.mp4","type":"video/mp4"},"hls":{"label":"hls","src":"https://ak-storage-west.teamcococdn.com/cdn/2018-07/104328/bca7/main.m3u8","type":"application/x-mpegurl"},"uhd":{"label":"uhd","src":"https://ak-storage-west.teamcococdn.com/cdn/2018-07/104328/bca7/CONAN_072218_Comedy_5-1080-6mb.mp4","type":"video/mp4"},"low":{"label":"low","src":"https://ak-storage-west.teamcococdn.com/cdn/2018-07/104328/bca7/CONAN_072218_Comedy_5-500k.mp4","type":"video/mp4"}}}}

@jmraker
Copy link

jmraker commented Sep 24, 2018

Actually the url is http://teamcoco.com/_truman/d/104328?v=v1536871782669

For the ?v=v1536871782669, it'll return the same json without that parameter (I was trying the url without it when I replied). It's probably from http://teamcoco.com/_truman/f/clips-v1536871782669.html where the http://teamcoco.com/_truman/d/104328 is assembled from concatenated constants there. Not sure where v1536871782669 comes from, perhaps it's the result of some javascript equation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[teamcoco] ERROR: An extractor error has occurred.
2 participants