Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[picta] Add new extractor #19094

Closed
wants to merge 24 commits into from
Closed

Conversation

oleksis
Copy link

@oleksis oleksis commented Feb 2, 2019

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • [ x] I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • [x ] New extractor
  • New feature

Description of your pull request and other information

Add new extractor for site Picta Cuban Audiovisual Content Platform

Example:
youtube-dl -v --no-check-certificate https://www.picta.cu/medias/818

@dstftw
Copy link
Collaborator

dstftw commented Feb 2, 2019

Read coding conventions.
Also www.picta.cu does not look reachable.

@oleksis
Copy link
Author

oleksis commented Apr 6, 2019

Fix KeyError when missing attributes in MPD #20588

@oleksis
Copy link
Author

oleksis commented Apr 18, 2019

@dstftw is possible check review this commit #0fc37c4
I need for my PictaExtractor pass checks in Travis CI
Thanks!

@dstftw
Copy link
Collaborator

dstftw commented Apr 18, 2019

Remove all unrelated changes from this PR.

@oleksis
Copy link
Author

oleksis commented Apr 19, 2019

@dstftw @remitamine Removed all unrelated changes from PictaExtractor ;)

@oleksis
Copy link
Author

oleksis commented May 25, 2020

@dstftw @remitamine Update to API v2 Picta for PictaExtractor. You can do a review. I would appreciate your comments. Thank you!

@dstftw
Copy link
Collaborator

dstftw commented May 25, 2020

Not possible to test/check since picta.cu does not look to be reachable.

@oleksis
Copy link
Author

oleksis commented May 25, 2020

@dstftw For us it is reachable from Cuba. I hope that one day it can be reached worldwide. Thanks and regards!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defunct PR source branch is not accessible pending-fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants