[Stitcher] - Reorganized call to json data accessing of {config} and … #20811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…{feed} to support return of show_title and publication_date in response to ticket #20510
dstftw
requested changes
Apr 25, 2019
| # Safe grab 'config' json data using get() | ||
| config = self._parse_json( | ||
| js_to_json(self._search_regex(r'(?s)var\s+stitcher(?:Config)?\s*=\s*({.+?});\n', webpage, 'episode config')), | ||
| display_id).get('config') |
There was a problem hiding this comment.
No, this does not make any sense.
| display_id).get('config') | ||
|
|
||
| # Safe grab 'episode' json data using get() | ||
| episode = config.get('episode') |
| episode = config.get('episode') | ||
|
|
||
| # Safe grab 'episode' json data using get() | ||
| feed = config.get('feed') |
There was a problem hiding this comment.
No, this does not give your any safety.
| @@ -69,12 +88,16 @@ def _real_extract(self, url): | |||
| r'Episode Info:\s*</span>([^<]+)<', webpage, 'description', fatal=False) | |||
| duration = int_or_none(episode.get('duration')) | |||
| thumbnail = episode.get('episodeImage') | |||
| pub_date = episode.get('pubDate') | |||
| show_name = feed.get('name') | |||
ThirumalaiK
pushed a commit
to ThirumalaiK/youtube-dl
that referenced
this pull request
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…{feed} to support return of show_title and publication_date in response to ticket #20510
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Responding to @wertercatt's open ticket (Ticket #20510) for poor metadata extraction of Stitcher URLs, I added the support to display the show that uploaded the podcast episode as well as the release/publication date in the info_dict object. These two items are encoded as "show_name" and "publication_date".
A test case was added to test the new functionality of "show_name" and "publication_date".
Subsequently, I noticed that the contribution and coding practice guidelines recommending using the get() method to better support backwards compatibility so that the extractor code does not break. Therefore, I reformatted the previous calls to self._parse_json() to utilize the get() method to extract data from ['config']['episode'] and ['config']['feed'] for "show_name" and "publication_date" respectively.