Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON schema prototype #21822

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

JSON schema prototype #21822

wants to merge 6 commits into from

Conversation

sanyarnd
Copy link

@sanyarnd sanyarnd commented Jul 18, 2019

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense

What is the purpose of your pull request?

  • Improvement
  • New feature

Currently youtube-dl JSON output has no schema, information about JSON is scattered across doc-strings and markdown-docs and it's was cumbersome to write bindings for it.

Another point is that the lack of schema does not guarantee any comparability, though I doubt there would be significant changes, but it's nice to have anyway.

There was an attempt to submit schema in the past (#16353), but that schema doesn't cover whole json output and not really structured. I think it's better to keep separate PRs, yet I don't mind moving discussion to that topic.
Also I don't mind collaboration with the dev team and cut some unnecessary parts if required or add some missing parts or any work on python side.

You can run tests for validation online here, but for some reason site does not understand $schema keyword -- simply remove it. I don't know why they don't support it, because it's the strongly recommended to have this field.

@Tatsh Tatsh mentioned this pull request Nov 17, 2020
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant