Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gaana] Add new extractor #22095

Closed
wants to merge 2 commits into from
Closed

[gaana] Add new extractor #22095

wants to merge 2 commits into from

Conversation

nikhgupta
Copy link

@nikhgupta nikhgupta commented Aug 14, 2019

Before submitting a pull request make sure you have:

Found an existing Gaana extractor in #18530 - this PR aims to improve upon that.

  • Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

There have been several requests for support regarding Gaana.com #12575, #18530, etc. This PR improves upon the code in #18530 by adding valid tests, improving playlist creation, and adheres to youtube-dl conventions as much as I could.

Please, let me know if anything else is required to get this integrated into the core.

Copy link
Collaborator

@dstftw dstftw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read coding conventions and fix code.

@SVB-commits
Copy link

❤️

@santhosh-v
Copy link

Any update on this ?

@dirkf dirkf closed this Aug 1, 2023
@dirkf dirkf added the defunct PR source branch is not accessible label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants