[bbc] Fix errors #23415
Closed
[bbc] Fix errors #23415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes errors on news articles, archive pages, etc
|
Fixes #23232 |
This was referenced Mar 16, 2020
Closed
|
@dstftw @remitamine |
dstftw
requested changes
Mar 23, 2020
youtube_dl/extractor/bbc.py
Outdated
Comment on lines
986
to
988
| r'"vpid":"(%s)"' % self._ID_REGEX, | ||
| r'"versionPid":"(%s)"' % self._ID_REGEX, | ||
| r'"pid":"(%s)"' % self._ID_REGEX], |
There was a problem hiding this comment.
- Provide concrete example URLs for each pattern. Add tests.
- Relax regexes.
There was a problem hiding this comment.
- "vpid" parameter is used for pre-existing test https://www.bbc.co.uk/bbcthree/clip/73d0bbd0-abc3-4cea-b3c0-cdae21905eb1
"pid" parameter is used for pre-existing test http://www.bbc.com/sport/0/football/33653409
Comments for these previously broken test have been amended to represent this. I can't remember what "versionPid" applied to so I removed it. - Relax in what way? I think this adequately captures programme ID from standard JSON data?
|
@dstftw @remitamine I have not seen any activity on this for weeks, please can you help move this along? |
|
Still awaiting review after 3 months. @dstftw @remitamine @phihag |
|
Any news about merging this? Thanks! @dstftw @remitamine @phihag |
Fixed news videos by implementing new window.__INITIAL_DATA__ data, and also fixed Morph videos.
flake8
ghost
mentioned this pull request
|
Is this still relevant given c32a059 ? |
Closed
|
I believe this is now superseded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes errors on news articles, archive pages, etc
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Fixes the errors on news article pages, archive pages, etc.