-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vlaretv] Add new extractor #24327
[Vlaretv] Add new extractor #24327
Conversation
youtube_dl/extractor/vlaretv.py
Outdated
import re | ||
|
||
|
||
class VlaretvIE(InfoExtractor): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Covered by generic extractor. Remove.
youtube_dl/extractor/vlaretv.py
Outdated
|
||
|
||
class VlaretvPlaylistIE(InfoExtractor): | ||
_VALID_URL = r'https?://vlare.tv/u/(?P<Channel_id>[0-9a-zA-Z]+)/playlist/(?P<id>[0-9]+)' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dots not escaped.
youtube_dl/extractor/vlaretv.py
Outdated
|
||
class VlaretvPlaylistIE(InfoExtractor): | ||
_VALID_URL = r'https?://vlare.tv/u/(?P<Channel_id>[0-9a-zA-Z]+)/playlist/(?P<id>[0-9]+)' | ||
IE_NAME = 'Vlare.tv Playlist' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove.
youtube_dl/extractor/vlaretv.py
Outdated
'_type': 'url_transparent', | ||
'url': 'https://vlare.tv' + i, | ||
'id': re.match(r'\/v\/(.+?)\/', i), | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
url_result
.
youtube_dl/extractor/vlaretv.py
Outdated
'title': title, | ||
'id': self._match_id(url), | ||
'entries': entries, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
playlist_result
.
youtube_dl/extractor/vlaretv.py
Outdated
return { | ||
'_type': 'playlist', | ||
'title': title, | ||
'id': self._match_id(url), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already extracted in code.
youtube_dl/extractor/vlaretv.py
Outdated
|
||
webpage = self._download_webpage(url, playlist_id) | ||
urls = re.findall(r'<a href="(.+?)" class="video_thumbnail"', webpage) | ||
title = self._html_search_regex(r'<title>(.+?)<\/title>', webpage, 'title').split('|')[1][1:-1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaks.
youtube_dl/extractor/vlaretv.py
Outdated
for i in urls: | ||
entry = { | ||
'_type': 'url_transparent', | ||
'url': 'https://vlare.tv' + i, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
urljoin
.
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Added support for vlare.tv (Single videos and Playlists)