-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GoogleDrive] fix redirect loop (closes #23919) #24689
Closed
legraphista
wants to merge
2
commits into
ytdl-org:master
from
legraphista:fix/google-drive-cookie-issue
Closed
[GoogleDrive] fix redirect loop (closes #23919) #24689
legraphista
wants to merge
2
commits into
ytdl-org:master
from
legraphista:fix/google-drive-cookie-issue
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstftw
requested changes
Apr 8, 2020
Confirming the bug and the patch with version 2020.03.24. Is anything else needed to merge this PR? Anything I can do to help? Thanks |
this would be great if merged, cc @dstftw |
#24689 fixed the issue for me |
any updates on this? Can this be merged? cc @dstftw |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
During the extractor of GoogleDrive, some cookies are set in the downloader cookiejar.
Upon inspecting issue #23919 i've noticed that a cookie set on
.google.com
was the root cause of the redirect loop (Google did an oopsie)When running a request on the extracted source, everything works as expected
curl -IL -XGET "https://drive.google.com/uc?id=1DIi4JBVXA3kihcTWr55paCt5aZyEVl83&export=download"
Output
But when running the request with the cookies on '.google.com' set from the extractor stage it enters a redirect loop
curl -IL -XGET "https://drive.google.com/uc?id=1DIi4JBVXA3kihcTWr55paCt5aZyEVl83&export=download" -H "Cookie: NID=201=Vgdy2UVlwmt4HOaKTwoCft7zHAslUJgpK1k7c0n5thYEgEFUurnNpeaUmcKlEvnHloFyzwdTks09P7H7QR7gGf2u2Z3qke9Vhxh87bhVi6M7MiMIBujKJfeMZ1hI3duoNUK8_gsysXvKeQxvW5T_cfdlYpH9i02h6Ai7LHe4bGY"
Output
The fix consists in clearing the
.google.com
cookies when extraction is finishedI've tested the source and the derived/processed video formats with this change and now they all work.