Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mediaklikk] Add new extractor #25098

Closed
wants to merge 6 commits into from
Closed

Conversation

mrx23dot
Copy link

@mrx23dot mrx23dot commented May 2, 2020

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Added extractor for this site: https://mediaklikk.hu/video/kiberma-2020-04-30-i-adas/

fixes #21431

@mrx23dot mrx23dot mentioned this pull request May 2, 2020
9 tasks
@mrx23dot mrx23dot changed the title New extractor: Mediaklikk [mediaklikk] Add new extractor May 2, 2020
@mrx23dot mrx23dot mentioned this pull request May 2, 2020
5 tasks
@mrx23dot mrx23dot closed this May 4, 2020
@mrx23dot mrx23dot reopened this May 4, 2020
@asalamon74
Copy link

I tested it, I successfully downloaded videos from m4sport.hu.

I had to modify only one line:

_VALID_URL = r'https?://(?:www\.)?(?:mediaklikk|m4sport)\.hu/videok?/(?P<id>[^/]+)/?'

@mrx23dot
Copy link
Author

Added m4sport support, what do I need to do with this pull request to get processed?

@dstftw dstftw force-pushed the master branch 2 times, most recently from 5e26784 to da2069f Compare September 13, 2020 13:50
@pizzasok
Copy link

pizzasok commented Sep 20, 2020

I also tested it, and I successfully downloaded videos from hirado.hu as well.

Like asalamon74 I had to modify only one line:

_VALID_URL = r'https?://(?:www.)?(?:mediaklikk|m4sport|hirado).hu(/\w+)*/(?P[^/]+)/?'

@pizzasok
Copy link

Also note that the video that is listed in the pull request description, and is included in mediaklikk.py as test, is no longer available. I suggest updating these to a video that is likely to be more permanently present on the site, e.g. :

https://mediaklikk.hu/adal2020/video/2020/03/07/a-dal-donto/

@pizzasok
Copy link

Thank you for including the hirado.hu fix! I created a pull request with a few minor additional edits, please accept if you agree with them. Also please update in the description of your pull request the link from https://mediaklikk.hu/video/kiberma-2020-04-30-i-adas/ to https://mediaklikk.hu/adal2020/video/2020/03/07/a-dal-donto/

@VinhoXie
Copy link

Thank you for including the hirado.hu fix! I recently found an article offering solutions to download video from mediaklikk too.

pukkandan pushed a commit to yt-dlp/yt-dlp that referenced this pull request Sep 6, 2021
nixxo pushed a commit to nixxo/yt-dlp that referenced this pull request Nov 22, 2021
@dirkf dirkf closed this Aug 1, 2023
@dirkf dirkf added the defunct PR source branch is not accessible label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defunct PR source branch is not accessible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for MédiaKlikk (HU)
5 participants