[BritishCouncil] Add new extractor #25424
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You must delegate to viddler extractor not inherit from it. |
|
Right, I understand. Sorry, didn't quite understand the convention. |
|
|
Thanks, I've updated my regex to meet coding conventions. All three embed options in your link will now be caught by the generic extractor. Let me know any additional touch ups are required. Thanks! |
dstftw
requested changes
Jun 5, 2020
| webpage) | ||
| if mobj is not None: | ||
| return ViddlerIE._build_url_result(mobj.group('id')) | ||
|
|
There was a problem hiding this comment.
Move embed extraction code to ViddlerIE._extract_urls.
Comment on lines
+77
to
+84
| @staticmethod | ||
| def _url_for_id(id): | ||
| return 'http://www.viddler.com/v/%s' % id | ||
|
|
||
| @classmethod | ||
| def _build_url_result(cls, id): | ||
| return cls.url_result(cls._url_for_id(id), | ||
| ie=cls.ie_key()) |
dstftw
force-pushed
the
master
branch
2 times, most recently
from
5e26784
to
da2069f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
New extractor for britishcouncil.org videos as requested by #25368
As the website uses Viddler as a provider, I've added a base Viddler IE to limit code repetition.
All tests pass and code has been check with flake8.