Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotstar] Move to API v1 #25443

Closed
wants to merge 1 commit into from
Closed

[hotstar] Move to API v1 #25443

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented May 28, 2020

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.

fixes #25003,#24707,#25003,#25042

@lzzy12
Copy link

lzzy12 commented Jun 9, 2020

Can confirm this fixes OTHERWISE completely useless hotstar support.. Thanks

@Abhishek890
Copy link

Yeah its fixed I tried you can download free videos

@Liupold
Copy link

Liupold commented Jun 16, 2020

youtube-dl --verbose 'https://www.hotstar.com/in/tv/mahapeeth-tarapeeth/s-1991/ma-tara-is-enraged/1000246671'

[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--verbose', 'https://www.hotstar.com/in/tv/mahapeeth-tarapeeth/s-1991/ma-tara-is-enraged/1000246671']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] youtube-dl version 2020.05.08
[debug] Python version 3.8.3 (CPython) - Linux-5.7.2-arch1-1-x86_64-with-glibc2.2.5
[debug] exe versions: ffmpeg 4.2.3, ffprobe 4.2.3
[debug] Proxy map: {}
[hotstar] 1000246671: Downloading webpage
[hotstar] 1000246671: Downloading token
[hotstar] 1000246671: Downloading JSON metadata
ERROR: Unable to download JSON metadata: HTTP Error 403: Forbidden (caused by <HTTPError 403:
'Forbidden'>); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see https://yt-dl.org/update on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
File "/home/rohnch/.local/lib/python3.8/site-packages/youtube_dl/extractor/common.py", line
627, in _request_webpage
return self._downloader.urlopen(url_or_request)
File "/home/rohnch/.local/lib/python3.8/site-packages/youtube_dl/YoutubeDL.py", line 2238, in urlopen
return self._opener.open(req, timeout=self._socket_timeout)
File "/usr/lib/python3.8/urllib/request.py", line 531, in open
response = meth(req, response)
File "/usr/lib/python3.8/urllib/request.py", line 640, in http_response
response = self.parent.error(
File "/usr/lib/python3.8/urllib/request.py", line 569, in error
return self._call_chain(*args)
File "/usr/lib/python3.8/urllib/request.py", line 502, in _call_chain
result = func(*args)
File "/usr/lib/python3.8/urllib/request.py", line 649, in http_error_default
raise HTTPError(req.full_url, code, msg, hdrs, fp)

doesn't seems to work.

@SpEcHiDe
Copy link
Contributor

hotstar is only available in India.
I can confirm that this PR is working fine for me.

@kamikazechaser
Copy link

kamikazechaser commented Jul 10, 2020

@dstftw Could this be merged asap (very popular site), I understand that you may need to test with a proxy to confirm.

@lzzy12
Copy link

lzzy12 commented Jul 31, 2020

Oof when will this be merged.. have to maintain forked repo for hotstar :/

@ytdl-org ytdl-org deleted a comment from blackjack4494 Sep 6, 2020
@ytdl-org ytdl-org locked and limited conversation to collaborators Sep 6, 2020
@dstftw dstftw force-pushed the master branch 2 times, most recently from 5e26784 to da2069f Compare September 13, 2020 13:50
@ghost ghost closed this by deleting the head repository Feb 27, 2023
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hotstar downloads are not working anymore (not a Geo-restriction problem).
6 participants