-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Youtube] Support 256kbps aac audio in youtube music #26160
Conversation
You must provide premium account. |
Sadly youtube wouldn't allow to download 256kbps aac without premium subscription. But current youtube-dl couldn't download 256kbps aac even if I have provided yt premium account cookie. It fixes that. |
If it helps anyone, YouTube is currently offering a free month trial of Premium. I upgraded my account about a week ago, but I believe they are still offering the trial. No payment required until the first renewal date of 30 days. |
Hi! If the free trial is not an option, I am willing to provide a donation to any of the core developers to cover premium subscription for a couple of months, if that would help with:
|
I can give my account info. |
5e26784
to
da2069f
Compare
I tried manually making these changes to youtube.py in the latest master and running it. It still works but I noticed an issue - it doesn't work on playlists, only individual videos. For instance I can run it on the Megalovania track linked in the OP and format 141 is there. But if I run it on this playlist with Megalovania at the top, there is no format 141. Update: Looks like the issue is with line 1781 of the original commit. If I just set 'is_music' to 1 instead of doing the regex, it works on playlists. Something's going wrong with that regex test. Update2: This is also breaking tags for the output file such as "%(artist)s", "%(album)s" etc which work in the master. They all evaluate to "NA" after making the change. |
It supposedly works but the maintainers aren't adding it in. |
Plus, surely you can deactivate/cancel the auto-renewal right after taking up the trial, so you won't have to do it right before the auto-renewal proceeds. |
Is there any news on this? I would be really grateful for this option! |
apply this commit to release of december 2020. and do #26160 (comment). |
Please refer #28778 for future update because my pull request branch is taken down :( |
Based on: ytdl-org/youtube-dl#28778, ytdl-org/youtube-dl#26160 Co-authored-by: craftingmod, colethedj, pukkandan
Based on: ytdl-org/youtube-dl#28778, ytdl-org/youtube-dl#26160 Co-authored-by: craftingmod, colethedj, pukkandan
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.
If provided url is youtube music, It will try get_video_info GET request with youtube music player parameter.
With cookie auth, Youtube premium member could download 256kbps aac audio in some supported music video. (Example: Megalovania)