[youtube] Fixed 'next_link' regular expression #26163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
This is the associated issue: #26161 |
Crypto90
added a commit
to Crypto90/youtube-dl
that referenced
this pull request
Jul 30, 2020
Added changes from this pull request for broken next page parsing: ytdl-org/youtube-dl#26163
|
This patch doesn't seem to work unfortunately |
dstftw
force-pushed
the
master
branch
2 times, most recently
from
5e26784
to
da2069f
Compare
RedpointsBots
force-pushed
the
bugfix_youtube_nextlink
branch
from
91b27e9
to
6807360
Compare
Can you give more information about what isn't working for you? This change is still fixes pagination for me. |
|
No longer actual. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
The current regular expression used to find the next page link of the search results does not work. As a result, no link is found and there is an unintentional limit to the first page of search results (20 results. If a search is made for with a specified limit of 50, youtube-dl will not find a link to the next page and report that only 20 results were found (even if there were more on any potential next pages).
This PR updates the regular expression in question. Rather than removing the offending part of the regex, I have simply made it optional for backwards compatibility or in case the next page link is changed back.