Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kakao Extractor #26577

Closed
wants to merge 1 commit into from
Closed

Fix Kakao Extractor #26577

wants to merge 1 commit into from

Conversation

wagwan-piffting-blud
Copy link

@wagwan-piffting-blud wagwan-piffting-blud commented Sep 13, 2020

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Kakao has changed their API to return null for clipChapterThumbnailList, this change comments out the thumbnail extractor to fix the issue.

Kakao has changed their API to return `null` for `clipChapterThumbnailList`, this change comments out the thumbnail extractor to fix the issue.
@zackmark29
Copy link

Why I'm getting this error?
C:\Users\MARK>youtube-dl -F https://tv.kakao.com/channel/3643855/cliplink/412069491
[Kakao] 412069491: Downloading video info
[Kakao] 412069491: Downloading video URL for profile LOW
[Kakao] 412069491: Downloading video URL for profile BASE
[Kakao] 412069491: Downloading video URL for profile MAIN
[Kakao] 412069491: Downloading video URL for profile HIGH
[Kakao] 412069491: Downloading video URL for profile HIGH4
Traceback (most recent call last):
File "main.py", line 19, in
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpq2whuxta\build\youtube_dl_init_.py", line 474, in main
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpq2whuxta\build\youtube_dl_init_.py", line 464, in _real_main
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpq2whuxta\build\youtube_dl\YoutubeDL.py", line 2019, in download
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpq2whuxta\build\youtube_dl\YoutubeDL.py", line 797, in extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpq2whuxta\build\youtube_dl\extractor\common.py", line 530, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpq2whuxta\build\youtube_dl\extractor\kakao.py", line 120, in _real_extract
TypeError: 'NoneType' object is not iterable

@wagwan-piffting-blud
Copy link
Author

@zackmark29 That was the error I was getting on the old version of the file, try the new one linked in the commit. I tested with the one in the commit and it works fine.

@zackmark29
Copy link

@zackmark29 That was the error I was getting on the old version of the file, try the new one linked in the commit. I tested with the one in the commit and it works fine.

Alright. thanks

@zackmark29
Copy link

@zackmark29 That was the error I was getting on the old version of the file, try the new one linked in the commit. I tested with the one in the commit and it works fine.

Do you have compiled exe version?

@wagwan-piffting-blud
Copy link
Author

@zackmark29 That was the error I was getting on the old version of the file, try the new one linked in the commit. I tested with the one in the commit and it works fine.

Do you have compiled exe version?

I do not, however you can run python __main__.py https://tv.kakao.com/channel/3643855/cliplink/412069491 from your CLI and it should begin downloading then.

@zackmark29
Copy link

@zackmark29 That was the error I was getting on the old version of the file, try the new one linked in the commit. I tested with the one in the commit and it works fine.

Do you have compiled exe version?

I do not, however you can run python __main__.py https://tv.kakao.com/channel/3643855/cliplink/412069491 from your CLI and it should begin downloading then.

Ah alright. I'll try.

@zackmark29
Copy link

Still the same error. I already updated the kakao.py with your updated code.

@wagwan-piffting-blud
Copy link
Author

Still the same error. I already updated the kakao.py with your updated code.

That is strange... not sure what would be causing the error then as the affected code is commented out, and I was able to download the video fine on my end. Can you paste the error you got this time (even if it is the same as before)? I would also suggest double-checking to make sure the file is exactly matching what is shown here (especially around line 120 where the change is).

@zackmark29
Copy link

Still the same error. I already updated the kakao.py with your updated code.

That is strange... not sure what would be causing the error then as the affected code is commented out, and I was able to download the video fine on my end. Can you paste the error you got this time (even if it is the same as before)? I would also suggest double-checking to make sure the file is exactly matching what is shown here (especially around line 120 where the change is).

Thank you it's now working.
I forgot to comment the 'thumbnails': thumbs, from line 139

@wagwan-piffting-blud
Copy link
Author

Still the same error. I already updated the kakao.py with your updated code.

That is strange... not sure what would be causing the error then as the affected code is commented out, and I was able to download the video fine on my end. Can you paste the error you got this time (even if it is the same as before)? I would also suggest double-checking to make sure the file is exactly matching what is shown here (especially around line 120 where the change is).

Thank you it's now working.
I forgot to comment the 'thumbnails': thumbs, from line 139

Okay, glad to hear it's working for you now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants