Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bigmarker] Add new extractor #26838

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[bigmarker] Add new extractor #26838

wants to merge 1 commit into from

Conversation

serl
Copy link
Contributor

@serl serl commented Oct 8, 2020

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

BigMarker is a platform for webinars.

Unfortunately, I don't have many test URLs, that also means that I don't know if and how exactly extract more metadata.

@dstftw
Copy link
Collaborator

dstftw commented Oct 17, 2020

Read coding conventions.

@serl
Copy link
Contributor Author

serl commented Oct 18, 2020

@dstftw I guess it was about author being explosive if missing?

Anyway, there I'm parsing some Javascript on the page, is there a better way or regex is ok?

Thanks!

@cypheron
Copy link

I guess because of the huge backlog @dstftw doesn't actually check any code, he writes that "read the conventions" nonsense over all PR's without ever mentioning a specific thing. Hope that @dstftw can get off his horse and does some work, otherwise I don't know if my excitement about ytdl being back was really appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants