Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ChannelNewsAsia] Add new extractor #27133

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

fourjr
Copy link
Contributor

@fourjr fourjr commented Nov 21, 2020

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.

Extractor to download videos from Singapore news site https://www.channelnewsasia.com

@dstftw
Copy link
Collaborator

dstftw commented Nov 21, 2020

Read coding conventions.

@fourjr
Copy link
Contributor Author

fourjr commented Nov 21, 2020

I have updated the code to follow the conventions.

@cypheron
Copy link

I guess because of the huge backlog @dstftw doesn't actually check any code, he writes that "read the conventions" nonsense over all PR's without ever mentioning a specific thing. Hope that @dstftw can get off his horse and does some work, otherwise I don't know if my excitement about ytdl being back was really appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants