-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TASVideos] Add new extractor #27537
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your Pull Request looks clean, simple. Thank you for your contribution.
Change class name to reflect website's letter capitalization better. Co-authored-by: fossdd <fossdd@tutanota.com>
|
Now has playlist functionality! |
optional (fatal=False) because the website's layout forced me into an unreliably regex.
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
tasvideos.org is a website that hosts videos of tool-assisted speedruns in videogames.
According to it's legal notice :
"Movies published on this site were created by and for this site."
To watch a video on the site, click "watch now" below the thumbnail of an entry to display a video-player.
Alternatively, the site offers direct download links for various formats on each entry.
Example: http://tasvideos.org/4352M.html
"Playlists" are search results via the filters on the website. Each filter adds something to the URL,
but all URLs always starts with "tasvideos.org/Movies-.."
Example: http://tasvideos.org/Movies-Stars.html
I tried making this extractor as minimal as possible, to see if I got the hang of things.
Also - I had no choice but to add
video_url = "http://www." + self._search_regex( ...
Because the website's links don't contain the http prefix.
'M' is added to playlist video ID's to match the single video url id's format
(getting the id + 'M" suffix + download links in one regex proved too difficult)
answers - #26765
Since the addition of timer + credit, I'm trying to change the title field to:
'title': 'C64 L'Abbaye des Mortsin 02:36.7 by Mothrayas.',
(at _TEST)
But github doesn't let me.
Would like to avoid making a new PR, but I don't have the folder with the branch on my pc anymore...