Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix view_count, ytsearch section #27588

Closed
wants to merge 1 commit into from
Closed

fix view_count, ytsearch section #27588

wants to merge 1 commit into from

Conversation

ohnonot
Copy link

@ohnonot ohnonot commented Dec 30, 2020

Just like in issue #27051, and this commit.

Before submitting a pull request make sure you have:

  • Searched the bugtracker for similar pull requests
  • Read youtube-dl coding conventions and adjusted the code to meet them
  • Covered the code with tests (note that PRs without tests will be REJECTED)
  • Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

The changes are minimal, I just copied a small fix from current youtube-dl to a different section.

If any sort of licensing is required for that:

  • I am the author of this code and I am willing to release it under Unlicense

What is the purpose of your pull request?

  • Bug fix

Description of your pull request and other information

When using e.g.

youtube-dl --flat-playlist --dump-json "ytsearch10:some random search"

the view_count is messed up (usually 1/1000th of what it really is), just like described in #27051.
The fix is the same as in this commit, starting on line 3439 of the same file (youtube_dl/extractor/youtube.py).

Just like in issue #27051, and [this commit](284f830).
@ohnonot
Copy link
Author

ohnonot commented Jan 8, 2021

Nudge, bump!

@remitamine
Copy link
Collaborator

the code is a lot similar to the one in YoutubeTabIE, the same code should be resued here, instead of having to fix the code in multiple places every time.

pukkandan added a commit to yt-dlp/yt-dlp that referenced this pull request Jan 10, 2021
ThirumalaiK pushed a commit to ThirumalaiK/youtube-dl that referenced this pull request Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants