-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[youtube] Show if video is embeddable in info #27747
base: master
Are you sure you want to change the base?
Conversation
|
I can add the documentation, but if it is not going to be merged anyway since it is not "general purpose", then I am not going to bother with it. |
First of, it's not quite clear what's this meta field is about - allowing/not allowing to play in embedded players another sites or what? If so it may be considered generic as many video platforms have such option (e.g. vimeo, livestream). |
done |
in the case of vimeo, limelight, brightcove, etc..., embed might be restricted by certain conditions. |
@remitamine What values do you suggest? Should any string be allowed in addition to True/False? I am just trying to implement this in youtube.com. I am not really familiar with the other extractors |
i'm pointing that using a boolean value might not be the right choice(how this would be implemented is up to you and what the review process will lead to).
a general purpose meta field should work with the majority of extractors and not only for a specific extractor(trying to avoid the need in the future to add another fields specific to every extractor which will make it more difficult for third parties to consume the info dict). |
a9d9add
to
26ebfc9
Compare
I have changed the description to
I dont know what else to change it to. If you think it should be needs further modification, please make a review commit |
26ebfc9
to
2afbd18
Compare
Can it get merged? |
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Adds a new key
playable_in_embed
in youtube.py infodictCloses #27730