Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Youvi] Add new extractor #27784

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[Youvi] Add new extractor #27784

wants to merge 4 commits into from

Conversation

EdenOvrutskiy
Copy link

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

closes #27014

Downloads youvi videos, bypasses NSFW registration, delegates to youtube/vimeo when needed

Comment on lines +48 to +53
if external_embed == 'youtube':
return self.url_result(external_id, 'Youtube')

elif external_embed == 'vimeo':
return self.url_result(
'https://vimeo.com/' + external_id, 'Vimeo')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests for such embeds.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extractor should not return None.


formats = []
for url_type in ('url', 'hls'):
url = self._search_regex(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not shadow outer names.

r'source_file:[^}]+(?:%s):"(?P<url>[^"]+?)"' % url_type,
webpage, 'youvi-hosted-url', fatal=False)
if url:
url = url.replace(r'\u002F', r'/')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if there are more escape codes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Youvi.ru support
2 participants