Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify meaning of "best" quality (bitrate vs. framerate, etc.) in readme #28326

Closed
wants to merge 1 commit into from
Closed

Conversation

ToaKraka
Copy link

@ToaKraka ToaKraka commented Mar 3, 2021

Fixes #28307

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

  • Searched the bugtracker for similar pull requests
  • (the other bullet points are not applicable; this is just editing the readme, not actual code)

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Clarifies (in the readme, not in any actual code) the method by which "best" or "worst" quality is determined, for users who are confused when the highest-framerate video is not downloaded by default

@ToaKraka ToaKraka changed the title Update README.md Clarify meaning of "best" quality (bitrate vs. framerate, etc.) in readme Mar 3, 2021
@dstftw
Copy link
Collaborator

dstftw commented Mar 3, 2021

How youtube-dl implements this logic is an implementation detail and may change any time. Moreover this logic may vary from extractor to extractor.

@dstftw dstftw closed this Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify meaning of "best" video quality (bitrate vs. framerate) in readme
2 participants