[bbc] Improve iPlayer extraction for audio description #28540
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
In issue #22986, the reporter noted that the audio-described version of an iPlayer programme was not retrieved when using the AD URL. This seems wrong.
The extractor used playlist data from http://www.bbc.co.uk/programmes/PID/playlist.json, but this doesn't include the AD version. @Vangelis66 (thanks) pointed out some places where playlist data including the AD version might be found.
On investigation it seems that the new React/Redux version of iPlayer sends JS that sets the application state from JSON, and this JSON includes all the data that is needed for iPlayer extraction.
This technique might render the tactics previously implemented in the extractor obsolete, but I left them in as fall-backs.
Instead of fetching the iPlayer page from the given URL, it would be possible to get similar data from IBL (NB slightly different keys, eg REDUX
episode
vs IBLepisodes
). However, the other (possibly obsolete) extraction tactics require the page, so at the moment the REDUX data is available with no further requests.Resolves #22986.