WIP: fix for password protected videos #28695
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For videos like http://vimeo.com/68375962 we had: Unable to download JSON metadata: HTTP Error 403: Forbidden
|
the tests pass without a problem both in CI and locally without any changes: |
|
Here (in France, maybe they started screwing up only in France?) I have this (and same with python2) (on Debian Sid) using 545d6cb: |
|
What the… I tried to test with proxies outside of France but none of them seem to work anyway, then I tested from another ISP using a SOCKS proxy through SSH… And it works. So basically it only fails from a connection at Free, while it works fine from Orange. Either my ISP is doing some weirder things that I knew they do, or Vimeo decided to piss off Free in some way… I thought it was why the password is asked twice (once on the page, then once again in the player on the black background), but no, it also happens from the Orange connection. |
|
Asked others on Mastodon and it seems to confirm the case… |
|
Another explanation would be not all their frontal servers have the same version and depending on the IP you use to connect you get one or the other… someone reported they heard an issue with Orange as well… |
|
when I try to access password-protected videos using a french proxy, Vimeo is asking for the password twice, this is clearly a bug that should be addressed by Vimeo on their website. |
|
Except the test actually works from another connection where the web browser does ask the password twice… go figure. |
|
Couldn't find their bug tracker so asked them on twitter, let's see… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems accessing password-protected videos have changed. Checking one from vimeo.com I noticed it was POSTing to player.vimeo.com for check-password and noticed the only codepath doing it in the extractor was not taken.
It also happens for videos already in the tests:
For videos like http://vimeo.com/68375962 we had:
Unable to download JSON metadata: HTTP Error 403: Forbidden
I'm not yet sure if it's required every time or if it should be conditional to some URL match though…