Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vimeo] Add extractor for event media #29389

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dirkf
Copy link
Contributor

@dirkf dirkf commented Jun 25, 2021

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

As reported in issue #29380 and documented here, Vimeo supports embedded media for events, with URLs not supported by the current Vimeo extractors.

This PR adds an extractor for such embedded media and also adds the embed pattern to the list that is used for the generic extractor.

Closes #29380.

@dirkf dirkf force-pushed the df-vimeo-embed-patch branch 3 times, most recently from 248e9c6 to 76113ef Compare June 25, 2021 07:39
@dirkf dirkf changed the title Add extractor for Vimeo event media [Vimeo] Add extractor for event media Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vimeo embedded link fails with Error: no suitable InfoExtractor for URL
1 participant