-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support byte range for dash mpd #30279
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 29, 2021
9 tasks
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
Jan 27, 2024
* adapted from ytdl-org#30279 * thx former GH user kikuyan
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
Jan 27, 2024
* adapted from ytdl-org#30279 * thx former GH user kikuyan
11 tasks
dirkf
added a commit
that referenced
this pull request
Feb 2, 2024
* adapted from #30279 * thx former GH user kikuyan
dirkf
added a commit
that referenced
this pull request
Feb 2, 2024
* adapted from #30279 * thx former GH user kikuyan
github-actions bot
added a commit
to hellopony/youtube-dl
that referenced
this pull request
Feb 2, 2024
* https://github.com/ytdl-org/youtube-dl: [Vbox7IE] Sanitise ld+json containing unexpected characters * based on PR ytdl-org#29680 * added hack to force invoking `transform_source` * fixes ytdl-org#26218 [Vbox7IE] Improve extraction * DASH extraction no longer fails with new range support * but always find combined formats if available * suppress ineffective XFF geo-bypass (causes time-outs) * adapted from ytdl-org#29680 * thx former GH user kikuyan [InfoExtractor] Correctly resolve BaseURL in DASH manifest Specs: * ISO/IEC 23009-1:2012 section 5.6 * RFC 3986 section 5. [InfoExtractor] Support byte range for DASH * adapted from ytdl-org#30279 * thx former GH user kikuyan [downloader/dash] Support `range` in fragment (format f'{start}-{end}') * adapted from ytdl-org#30279 * thx former GH user kikuyan [InfoExtractor] Support DASH subtitle extraction (yt-dlp back-port)
dirkf
added a commit
to ytdl-org/ytdl-nightly
that referenced
this pull request
Feb 3, 2024
* adapted from ytdl-org/youtube-dl#30279 * thx former GH user kikuyan
dirkf
added a commit
to ytdl-org/ytdl-nightly
that referenced
this pull request
Feb 3, 2024
* adapted from ytdl-org/youtube-dl#30279 * thx former GH user kikuyan
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Add
range
andmediaRange
attributes support of these types to dash mpd parser:Also modified the existing code a bit at
# Segment URLs with no SegmentTimeline
inextractor/common.py
for clarity, IMO.Regarding the
ftyp
boxThere seem to be some mpds that do not include
ftyp
box in the initialization segment because the range doesn't start from 0. As a result, the downloaded files do not have the box either. Such mpds are, for example, https://kinescope.io/200615537/master.mpd in #30235 andurl_and_range.mpd
made with Bento4 I added for test to this PR.url_and_range.mpd
has<Initialization sourceURL="video-frag.mp4" range="36-746"/>
. If the source video file starts likethen the downloaded file will start like
This usually won't be a problem nor emerge because youtube-dl runs ffmpeg to merge video and audio, and the file will be adjusted. And for
m4a_dash
audio-only stream, fixup will be done.While the video-only file seems to play fine with, say, VLC and QuickTime Player, I'm thinking of making another PR to run ffmpeg for fixup.