Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nate] Add new site #30330

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[Nate] Add new site #30330

wants to merge 5 commits into from

Conversation

Hyeeji
Copy link

@Hyeeji Hyeeji commented Dec 7, 2021

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Closes #30236, qv.

@gerori
Copy link

gerori commented Dec 7, 2021 via email

youtube_dl/extractor/nate.py Outdated Show resolved Hide resolved
def _real_extract(self, url):
video_id = self._match_id(url)

video_data = self._download_json('https://tv.nate.com/api/v1/clip/' + str(video_id), video_id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or at least, it's not unicode. In yt-dl str should almost always be compat_str, but as above it's not needed here.

@dirkf
Copy link
Contributor

dirkf commented Aug 31, 2023

I've adapted the yt-dlp code that derived from this PR and updated this PR accordingly, with additional error-handling. The download tests all passed locally.

Testers welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Site-support-request/nate] Add new extractor
3 participants