Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SpankBang] Improve extractors #31010

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dirkf
Copy link
Contributor

@dirkf dirkf commented Jun 6, 2022

Boilerplate: mixed code, improvement ## Please follow the guide below
  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense, except where:
  • I am not the original author of this code but it is in public domain or released under Unlicense (yt-dlp/yt_dlp/extractor/spankbang.py)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

This PR updates the SpankBang extractor module. The main changes are:

  • SpankBangIE back-ported from yt-dlp (small changes)
  • SpankBangPlaylistIE reworked to support multi-page playlists.

Resolves #30728.

dirkf added 2 commits June 6, 2022 14:18
* improve title extraction
* add uploader_id
* update test
* but don't check file md5
@afterdelight
Copy link
Contributor

could you add channel page support?

@afterdelight
Copy link
Contributor

thanks!

@dirkf
Copy link
Contributor Author

dirkf commented Jan 17, 2023

See yt-dlp/yt-dlp#5156 (comment).

null2264 added a commit to null2264/yt-dlp that referenced this pull request Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Spankbang) Channels download possible?
2 participants