[SwitchTube] Add new extractor #31018
Conversation
belamenso
force-pushed
the
switchtube
branch
3 times, most recently
from
7f4e5e6
to
2d0e7d5
Compare
There was a problem hiding this comment.
Thanks for your work!
I've made quite a few suggestions, which is not to say that your originals were necessarily wrong, because Python gives you many ways to do things. Generally the suggestions focus on robustness and using similar code style to other extractors. Also, the suggestions haven't been tested!
I'll enable the workflow tests after you've been through the comments.
|
I updated the code either exactly as suggested or similarly. |
|
I believe I was missing |
|
Can someone please approve the CI tests? @dirkf |
|
I implemented the suggestions. |
|
Can somebody look into this? |
|
SwitchTube has apparently changes the playlist website format, making a large part of this extractor useless. PLEASE DO NOT MERGE. I will try to fix it in a week. |
belamenso
changed the title
belamenso
force-pushed
the
switchtube
branch
2 times, most recently
from
a39b781
to
6be0c71
Compare
|
I've split the previous |
belamenso
changed the title
… issues (ytdl-org#31153) * [test] Identify testcase errors better * [test] Identify download errors better * [extractor/minds] Linter * [extractor/aes] Linter
Based on and closes ytdl-org#26638.
…7b9 (ytdl-org#31170) * back-port from yt-dlp 8f53dc4, thanks pukkandan * also support void, improve <</>> precedence, improve expressions in comma-list * add more tests
* operator ??
* operator ?.
* operator **
* accurate operator functions
* `undefined` handling
* object literals {a: 1, "b": expr}
* more tests for weird JS comparisons: see ytdl-org#31173 (comment).
…#31182) * based on yt-dlp/yt-dlp@f6ca640, thanks pukkandan * adds parse support for regexp flags
* add compat_re_Pattern * improve compat_collections_chain_map * use class JS_Undefined * remove unused code
* proposed fix for issue ytdl-org#31131, aligns with yt-dlp Co-authored-by: dirkf <fieldhouse@gmx.net>
* also ensure compat encoding of error strings
* from yt-dlp/yt-dlp@164b03c * added tests
* fix version check
* add NaN * allow any white-space character for `after_op` * align with yt-dlp f26af78 (charcodeAt and bitwise overflow) * allow escaping in regex, fixing player c57c113c
* temporary fix for player 5a3b6271 [1] 1. yt-dlp/yt-dlp#4635 (comment)
Before submitting a pull request make sure you have:
Mostly, some lines are often longer than 80 columns, and no data point is extracted from more than a single source.
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
This pull request adds tube.switch.ch, probably the largest Swiss website for universities to share lecture videos.