Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Recurbate.com] Add Recurbate premium support #31306

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

mrscrapy
Copy link

@mrscrapy mrscrapy commented Oct 22, 2022

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

This Extractor adds support for Recurbate.com videos.
Access to the videos is still restricted under their premium plan, so it is necessary to use cookies from an active session via --cookies.

Resolves #28793

@mrscrapy mrscrapy changed the title Add Recurbate premium support [Recurbate.com] Add Recurbate premium support Oct 23, 2022
Copy link
Contributor

@dirkf dirkf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!

I think this PR is for a new site and has no linked site support issue, so I'll paste the necessary template into the main PR text for you to complete.

youtube_dl/extractor/recurbate.py Outdated Show resolved Hide resolved
youtube_dl/extractor/recurbate.py Outdated Show resolved Hide resolved
youtube_dl/extractor/recurbate.py Show resolved Hide resolved
youtube_dl/extractor/recurbate.py Outdated Show resolved Hide resolved
youtube_dl/extractor/recurbate.py Show resolved Hide resolved
youtube_dl/extractor/recurbate.py Outdated Show resolved Hide resolved
@mrscrapy mrscrapy requested a review from dirkf October 28, 2022 17:12
Copy link
Author

@mrscrapy mrscrapy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have addressed all the comments, I tested and I believe there are no more issues.

@dirkf dirkf added the nsfw label Nov 3, 2022
Copy link
Contributor

@dirkf dirkf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small update, force CI

youtube_dl/extractor/recurbate.py Outdated Show resolved Hide resolved
youtube_dl/extractor/recurbate.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recurbate.com
2 participants